jerryshao commented on PR #7662: URL: https://github.com/apache/gravitino/pull/7662#issuecomment-3061346608
> @jerryshao May I ask a question?, I've got unit tests written for the current issue, but I hit some significant code duplication with the existing update model tests. I've worked around it for now by changing the target string used in the test, but I'm wondering if there's a better, more idiomatic way to handle this in our codebase. Any thoughts on that? 🤔 > > Also, as I was digging in, I noticed quite a few methods using `RESTUtils.encodeString()` don't have dedicated encoding tests, not just in `GenericModelCatalog.java` but elsewhere too. For this PR, should I go ahead and add comprehensive encoding tests for all of those methods, or would it be better to just include the test directly relevant to this issue and then open a separate issue for broader encoding test coverage? > > Thanks!! I think you can only focus on the model-related interfaces, no need to cover all the other code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
