This is an automated email from the ASF dual-hosted git repository.
jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 914de4f4ef [#7665]remove duplicate properties code (#7678)
914de4f4ef is described below
commit 914de4f4ef57eadf3182bbc1305d8ef07ad37f7a
Author: kitoha <[email protected]>
AuthorDate: Mon Jul 14 08:42:43 2025 +0900
[#7665]remove duplicate properties code (#7678)
## [#7665] fix : remove duplicate properties code
### What changes were proposed in this pull request?
Removed the first setProperties insertion inside generateAlterTableSql
### Why are the changes needed?
When both a table comment and properties were modified in the same
operation, the old logic produced two SET TBLPROPERTIES clauses.
Fix: #7665
---
.../apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java | 3 ---
.../catalog/oceanbase/operation/OceanBaseTableOperations.java | 3 ---
2 files changed, 6 deletions(-)
diff --git
a/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
b/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
index 3d5dd58304..0c3caf473c 100644
---
a/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
+++
b/catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java
@@ -284,9 +284,6 @@ public class MysqlTableOperations extends
JdbcTableOperations {
"Unsupported table change type: " + change.getClass().getName());
}
}
- if (!setProperties.isEmpty()) {
- alterSql.add(generateTableProperties(setProperties));
- }
// Last modified comment
if (null != updateComment) {
diff --git
a/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
b/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
index 33b00d59ac..0428134b0e 100644
---
a/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
+++
b/catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java
@@ -299,9 +299,6 @@ public class OceanBaseTableOperations extends
JdbcTableOperations {
"Unsupported table change type: " + change.getClass().getName());
}
}
- if (!setProperties.isEmpty()) {
- alterSql.add(generateTableProperties(setProperties));
- }
// Last modified comment
if (null != updateComment) {