FANNG1 commented on PR #7397: URL: https://github.com/apache/gravitino/pull/7397#issuecomment-3071277547
> > > > > > > @FANNG1 Is the PR good? Any more changes required? > > > > > > > > > > > > > > > > > > LGTM except minor comments. > > > > > > > > > > > > > > > @FANNG1 Updated the rest of the comments. Assuming that this might get merged in 0.9.1 release the since field is mentioned for new fields in doc as 0.9.1. > > > > > > > > > > > > `0.9.1` is a bug fix release, could you propose the PR for the `main` branch and change the version in document? > > > > > > > > > changed release version to `0.10.0` . Retargeted the PR to the `main` branch, but shows a lot of changes and conflicts. It this is expected I will resolve the conflicts and re raise again. > > > > > > the latest version is `1.0.0`, and there are some unrelated changes in this PR, maybe you should using `git pull` to get lastest code and `get rebase -i master` to rebase your code. > > @FANNG1 Looks like I messed up very bad. Is it fine if I re raise a PR for this from another branch? sure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
