jerryshao commented on code in PR #7622:
URL: https://github.com/apache/gravitino/pull/7622#discussion_r2212068864
##########
catalogs/catalog-model/src/main/java/org/apache/gravitino/catalog/model/ModelCatalogOperations.java:
##########
@@ -524,6 +557,48 @@ private ModelVersion
internalGetModelVersion(NameIdentifier ident) {
}
}
+ private String internalGetModelVersionUri(
+ NameIdentifier modelIdent, NameIdentifier modelVersionIdent, String
uriName) {
Review Comment:
Do we support "null" uriName, if so, I would suggest using
`Optional<String>` to define this argument to make the code more clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
