mchades commented on code in PR #7697:
URL: https://github.com/apache/gravitino/pull/7697#discussion_r2212128140
##########
integration-test-common/src/test/java/org/apache/gravitino/integration/test/util/DownloaderUtils.java:
##########
@@ -34,11 +38,25 @@ public class DownloaderUtils {
public static final Logger LOG =
LoggerFactory.getLogger(DownloaderUtils.class);
+ // Supported driver types and their corresponding version extraction patterns
+ private static final Pattern MYSQL_DRIVER_PATTERN =
+ Pattern.compile("mysql-connector-java-([\\d.]+)\\.jar");
+ private static final Pattern POSTGRESQL_DRIVER_PATTERN =
+ Pattern.compile("postgresql-([\\d.]+)\\.jar");
+
public static void downloadFile(String fileUrl, String...
destinationDirectories)
throws IOException {
+
+ // Check and clean driver version conflicts before downloading
+ try {
+ checkAndCleanDriverConflicts(fileUrl, destinationDirectories);
Review Comment:
You are binding the driver validation with the file download, but the
downloadFile may not be a driver.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
