liunaijie commented on code in PR #7738:
URL: https://github.com/apache/gravitino/pull/7738#discussion_r2225552035
##########
catalogs/catalog-jdbc-common/src/main/java/org/apache/gravitino/catalog/jdbc/config/JdbcConfig.java:
##########
@@ -65,7 +66,7 @@ public class JdbcConfig extends Config {
.doc("The password of the Jdbc connection")
.version(ConfigConstants.VERSION_0_3_0)
.stringConf()
- .checkValue(StringUtils::isNotBlank,
ConfigConstants.NOT_BLANK_ERROR_MSG)
+ .checkValue(Objects::nonNull, ConfigConstants.NOT_BLANK_ERROR_MSG)
Review Comment:
This is because the StarRocks jdbc password is empty string. When I set the
password to empty string in `StarRocksContainer`. This Config check is fail
due to it's blank.
Due to this I am also update here
`[Config.java](https://github.com/apache/gravitino/pull/7738/files#diff-8918f298792aac4b08036dbde485791e97628dd67d399cb1d2dc0b7a6e7f4a55)`
In here it will filter the empty config value. but retaining empty values
may be necessary for some use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
