liunaijie commented on code in PR #7792:
URL: https://github.com/apache/gravitino/pull/7792#discussion_r2242171073
##########
core/src/main/java/org/apache/gravitino/Config.java:
##########
@@ -198,7 +198,7 @@ public void loadFromMap(Map<String, String> map,
Predicate<String> predicate) {
(k, v) -> {
String trimmedK = k.trim();
String trimmedV = v.trim();
- if (!trimmedK.isEmpty() && !trimmedV.isEmpty()) {
+ if (!trimmedK.isEmpty()) {
Review Comment:
When set property, empty key is meanless, we can filter it, but maybe the
empty value is valid is sometime. I think we don't need filter it in the
framework.
For example I want take a spike for Gravitino. I download it and want to
connect my dev mysql, the password is empty string.
Then I can't connect it as I just use an empty password.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
