hqbhoho commented on code in PR #7907: URL: https://github.com/apache/gravitino/pull/7907#discussion_r2252920817
########## docs/trino-connector/supported-catalog.md: ########## @@ -137,6 +137,7 @@ call gravitino.system.create_catalog( ``` A prefix with `trino.bypass.` in the configuration key is used to indicate Gravitino Trino connector to pass the Trino connector configuration to the Gravitino catalog in the Trino runtime. +Note that it is when a configuration property is explicitly defined in Gravitino that the `trino.bypass.`properties which for the same property will be skipped. Review Comment: Note that if Trino connector properties directly inherit values from Gravitino catalog, these configurations cannot be overridden through any `trino.bypass.*` properties. For example, the Trino MySQL connector properties `connection-url`, `connection-user` and `connection-password` directly inherit the `jdbc-url`, `jdbc-user` and `jdbc-password` values defined in the Gravitino MySQL catalog. Therefore, defining `trino.bypass.connection-url`, `trino.bypass.connection-user` or `trino.bypass.connection-password` is invalid and must be avoided. How about changing it like this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
