yuqi1129 commented on code in PR #7796:
URL: https://github.com/apache/gravitino/pull/7796#discussion_r2254151087
##########
core/src/main/java/org/apache/gravitino/SupportsRelationOperations.java:
##########
@@ -95,4 +120,31 @@ void insertRelation(
Entity.EntityType dstType,
boolean override)
throws IOException;
+
+ /**
+ * Updates the relations for a given entity by adding a set of new relations
and removing another
+ * set of relations.
+ *
+ * @param <E> The type of the entity returned in the list, which represents
the final state of
+ * related entities.
+ * @param relType The type of relation to update.
+ * @param entityIdentifier The identifier of the entity for which to update
relations.
Review Comment:
The identifier of the source of the relation or something similar. Please
emphasize that this is the src identifier of the relation to be updated.
##########
core/src/main/java/org/apache/gravitino/SupportsRelationOperations.java:
##########
@@ -95,4 +120,31 @@ void insertRelation(
Entity.EntityType dstType,
boolean override)
throws IOException;
+
+ /**
+ * Updates the relations for a given entity by adding a set of new relations
and removing another
+ * set of relations.
+ *
+ * @param <E> The type of the entity returned in the list, which represents
the final state of
+ * related entities.
+ * @param relType The type of relation to update.
+ * @param entityIdentifier The identifier of the entity for which to update
relations.
Review Comment:
Please update the Java doc of `entitiesToAdd` and `entitiesToRemove`
accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
