josephC45 opened a new pull request, #8000:
URL: https://github.com/apache/gravitino/pull/8000

   ### What changes were proposed in this pull request?
   Fixes the parameter order when calling JdbcUrlUtils.validateJdbcConfig in 
SqlSessionFactoryHelper.java. The method now receives driverClass as the first 
parameter and jdbcUrl as the second, as expected.
   Adds comprehensive unit tests in TestJdbcUrlUtils.java covering valid and 
invalid JDBC configurations.
   
   ### Why are the changes needed?
   JdbcUrlUtils.validateJdbcConfig validates the JDBC configuration by checking 
the driver class name and URL for unsafe parameters. Incorrect parameter order 
caused validation to run against the wrong values, leading to incorrect 
results. This fix ensures validation logic works as intended and improves test 
coverage.
   
   Fix: #7960 
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   ### How was this patch tested?
   Added unit tests for both successful and failure cases in 
TestJdbcUrlUtils.java. All tests pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to