justinmclean commented on code in PR #7988:
URL: https://github.com/apache/gravitino/pull/7988#discussion_r2265692180
##########
core/src/main/java/org/apache/gravitino/StringIdentifier.java:
##########
@@ -219,9 +219,9 @@ public static String removeIdFromComment(String comment) {
}
if (indexOf != -1) {
- return comment.substring(0, indexOf);
+ return comment.substring(0, indexOf).trim();
}
}
- return comment;
+ return comment.trim();
Review Comment:
This would change the comment even if it didn't have an identifier in it,
I'm not sure we want to do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
