mchades commented on code in PR #7690: URL: https://github.com/apache/gravitino/pull/7690#discussion_r2265919751
########## core/src/main/java/org/apache/gravitino/storage/relational/service/StatisticMetaService.java: ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.storage.relational.service; + +import java.util.List; +import java.util.stream.Collectors; +import org.apache.gravitino.Entity; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.NameIdentifier; +import org.apache.gravitino.meta.StatisticEntity; +import org.apache.gravitino.storage.relational.mapper.StatisticMetaMapper; +import org.apache.gravitino.storage.relational.po.StatisticPO; +import org.apache.gravitino.storage.relational.utils.SessionUtils; +import org.apache.gravitino.utils.NameIdentifierUtil; + +/** + * The service class for statistic metadata. It provides the basic database operations for + * statistic. + */ +public class StatisticMetaService { + + private static final StatisticMetaService INSTANCE = new StatisticMetaService(); + + public static StatisticMetaService getInstance() { + return INSTANCE; + } + + private StatisticMetaService() {} + + public List<StatisticEntity> listStatisticsByObject( + NameIdentifier identifier, Entity.EntityType type) { + long metalakeId = + MetalakeMetaService.getInstance() + .getMetalakeIdByName(NameIdentifierUtil.getMetalake(identifier)); + MetadataObject object = NameIdentifierUtil.toMetadataObject(identifier, type); + long entityId = + MetadataObjectService.getMetadataObjectId(metalakeId, object.fullName(), object.type()); + List<StatisticPO> statisticPOs = + SessionUtils.getWithoutCommit( + StatisticMetaMapper.class, + mapper -> mapper.listStatisticPOsByEntityId(metalakeId, entityId)); + return statisticPOs.stream().map(StatisticPO::fromStatisticPO).collect(Collectors.toList()); + } + + public void batchInsertStatisticPOs( + List<StatisticEntity> statisticEntities, + String metalake, + NameIdentifier entity, + Entity.EntityType type) { + if (statisticEntities == null || statisticEntities.isEmpty()) { + return; + } + Long metalakeId = MetalakeMetaService.getInstance().getMetalakeIdByName(metalake); + MetadataObject object = NameIdentifierUtil.toMetadataObject(entity, type); + Long entityId = + MetadataObjectService.getMetadataObjectId(metalakeId, object.fullName(), object.type()); + + List<StatisticPO> pos = + StatisticPO.initializeStatisticPOs(statisticEntities, metalakeId, entityId, object.type()); + SessionUtils.doWithCommit( + StatisticMetaMapper.class, mapper -> mapper.batchInsertStatisticPOs(pos)); Review Comment: If you delete the stats from the upper layer first, how can you roll back if the insert fails? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
