justinmclean opened a new issue, #8054:
URL: https://github.com/apache/gravitino/issues/8054

   ### What would you like to be improved?
   
   In 
core/src/main/java/org/apache/gravitino/storage/relational/service/TableColumnMetaService.java
 in updateColumnPOsFromTableDiff there is an issue with.
   
   ```
         // If the column is not existed in old columns, or if the column is 
updated, mark it as UPDATE
         if (oldColumn == null) {
           columnPOsToInsert.add(
               POConverters.initializeColumnPO(newTablePO, newColumn, 
ColumnPO.ColumnOpType.CREATE));
         } else if (!oldColumn.equals(newColumn)) {
           columnPOsToInsert.add(
               POConverters.initializeColumnPO(newTablePO, newColumn, 
ColumnPO.ColumnOpType.UPDATE));
         }
   ```
   
   
   ### How should we improve?
   
   The if statement should also check if the old column is not equal to the new 
column.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to