yuqi1129 commented on code in PR #8018: URL: https://github.com/apache/gravitino/pull/8018#discussion_r2272431801
########## mcp-server/mcp_server/client/plain/plain_rest_client_model_operation.py: ########## @@ -0,0 +1,68 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from mcp_server.client import ModelOperation + + +class PlainRESTClientModelOperation(ModelOperation): + """ + Implementation of ModelOperation using a plain REST client. + """ + + def __init__(self, metalake_name: str, rest_client): + self.metalake_name = metalake_name + self.rest_client = rest_client + + async def get_list_of_models( + self, catalog_name: str, schema_name: str + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/catalogs/{catalog_name}/schemas/{schema_name}/models" + ) + return response.json().get("identifiers", []) + + async def load_model( + self, catalog_name: str, schema_name: str, model_name: str + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/catalogs/{catalog_name}/schemas/{schema_name}/models/{model_name}" + ) + return response.json().get("model", {}) + + async def list_model_versions( + self, catalog_name: str, schema_name: str, model_name: str + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/catalogs/{catalog_name}/schemas/{schema_name}/models/{model_name}/versions" + ) + return response.json().get("versions", []) + + async def load_model_version( + self, catalog_name: str, schema_name: str, model_name: str, version: int + ) -> str: + response = await self.rest_client.get( + f"/api/metalakes/{self.metalake_name}/catalogs/{catalog_name}/schemas/{schema_name}/models/{model_name}/versions/{version}" + ) Review Comment: I have checked it. Module `mcp-server` uses `black` to detect and fix the format problem automatically, it will not modify a raw string like `f"xxxx"` to multiple lines, which is different from `pylint` as `pylint` will throw a message like `E501 line too long` Do we need to introduce the checker`pylint` and resolve extra-long fields as `black` and `isort` used in the module have already been set as follows: ```toml # content from ${GRAVITINO_HOME}/mcp-server/pyproject.toml [tool.isort] profile = "black" line_length = 80 multi_line_output = 3 include_trailing_comma = true force_grid_wrap = 0 use_parentheses = true [tool.black] line-length = 80 target-version = ['py38'] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
