hqbhoho commented on code in PR #7820:
URL: https://github.com/apache/gravitino/pull/7820#discussion_r2272691609
##########
docs/flink-connector/flink-connector.md:
##########
@@ -35,19 +35,30 @@ This capability allows users to perform federation queries,
accessing data from
| table.catalog-store.kind | string |
generic_in_memory | The Catalog Store name, it should set to `gravitino`.
| Yes | 0.6.0-incubating |
| table.catalog-store.gravitino.gravitino.metalake | string | (none)
| The metalake name that flink connector used to request to Gravitino. | Yes
| 0.6.0-incubating |
| table.catalog-store.gravitino.gravitino.uri | string | (none)
| The uri of Gravitino server address. | Yes
| 0.6.0-incubating |
+| table.catalog-store.gravitino.gravitino.client. | string | (none)
| The configuration key prefix for the Gravitino client config. | No
| 1.0.0 |
+
+To configure the Gravitino client, use properties prefixed with
`table.catalog-store.gravitino.gravitino.client.`. These properties undergo
automatic transformation: the prefix is replaced with `gravitino.client.` and
passed to the `GravitinoClient`.
+
+**Example:** Setting
`table.catalog-store.gravitino.gravitino.client.socketTimeoutMs` is equivalent
to setting `gravitino.client.socketTimeoutMs` for the `GravitinoClient`.
Review Comment:
In the code logic, I use `gravitino.client.` replace
`table.catalog-store.gravitino.gravitino.client.`.
So remove "These properties undergo automatic transformation: the prefix is
replaced with `gravitino.client.` and passed to the `GravitinoClient`" whether
is better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
