FANNG1 commented on code in PR #8045:
URL: https://github.com/apache/gravitino/pull/8045#discussion_r2276127240
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergCatalogPropertyConverter.java:
##########
@@ -107,4 +113,19 @@ private Map<String, String>
buildJDBCBackendProperties(Map<String, String> prope
return jdbcProperties;
}
+
+ private Map<String, String> buildRestBackendProperties(Map<String, String>
properties) {
+ Set<String> missingProperty =
+ Sets.difference(REST_BACKEND_REQUIRED_PROPERTIES, properties.keySet());
+ if (!missingProperty.isEmpty()) {
+ throw new TrinoException(
+ GravitinoErrorCode.GRAVITINO_MISSING_REQUIRED_PROPERTY,
+ "Missing required property for Rest backend: " + missingProperty);
+ }
+
+ Map<String, String> jdbcProperties = new HashMap<>();
+ jdbcProperties.put("iceberg.catalog.type", "rest");
Review Comment:
Does trino support other rest properties like warehouse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
