ankamde commented on code in PR #8070:
URL: https://github.com/apache/gravitino/pull/8070#discussion_r2276246495
##########
authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/jdbc/JdbcAuthorizationProperties.java:
##########
@@ -34,7 +34,7 @@ public JdbcAuthorizationProperties(Map<String, String>
properties) {
}
private void check(String key, String errorMsg) {
- if (!properties.containsKey(key) && properties.get(key) != null) {
+ if (!properties.containsKey(key)) {
Review Comment:
In the latest version I'm filtering out null values in
AuthorizationProperties - this way there is no need to check for null in check
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
