(gravitino) branch main updated: [#8055] improvement(core): Replace equals() with == for enum comparison in CompatibilityUtils (#8080)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new 27cdf27e0c [#8055] improvement(core): Replace equals() with == for 
enum comparison in CompatibilityUtils (#8080)
27cdf27e0c is described below

commit 27cdf27e0c10e4b9af265fac137164958ee33239
Author: keepConcentration <phm...@gmail.com>
AuthorDate: Fri Aug 15 11:39:21 2025 +0900

    [#8055] improvement(core): Replace equals() with == for enum comparison in 
CompatibilityUtils (#8080)
    
    ### What changes were proposed in this pull request?
    
    Replace `equals()` method with `==` operator for enum comparison in the
    `toAuditLogStatus()` method within `CompatibilityUtils` class.
    Additionally, add a null safety test case to ensure proper handling of
    null `OperationStatus` parameters.
    
    ### Why are the changes needed?
    
    1. Using `==` for enum comparison is more efficient than `equals()`
    since enums are singletons in Java
    2. Added test coverage for null parameter handling to ensure robustness
    
    Fix: #8055
    
    ### Does this PR introduce _any_ user-facing change?
    
    No, this is purely an internal refactoring change.
    
    ### How was this patch tested?
    
    1. Existing unit tests continue to pass, ensuring no functional
    regression
    2. Added a new test case `testOperationStatusNullHandling()` to verify
    proper null parameter handling
---
 .../main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java | 4 ++--
 .../java/org/apache/gravitino/audit/v2/TestCompatibilityUtils.java  | 6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git 
a/core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java 
b/core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java
index 93c9ff7358..6027809e4c 100644
--- a/core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java
+++ b/core/src/main/java/org/apache/gravitino/audit/v2/CompatibilityUtils.java
@@ -101,9 +101,9 @@ public class CompatibilityUtils {
   }
 
   static Status toAuditLogStatus(OperationStatus operationStatus) {
-    if (operationStatus.equals(OperationStatus.SUCCESS)) {
+    if (operationStatus == OperationStatus.SUCCESS) {
       return Status.SUCCESS;
-    } else if (operationStatus.equals(OperationStatus.FAILURE)) {
+    } else if (operationStatus == OperationStatus.FAILURE) {
       return Status.FAILURE;
     } else {
       return Status.UNKNOWN;
diff --git 
a/core/src/test/java/org/apache/gravitino/audit/v2/TestCompatibilityUtils.java 
b/core/src/test/java/org/apache/gravitino/audit/v2/TestCompatibilityUtils.java
index 3941a069a7..3021fdd56c 100644
--- 
a/core/src/test/java/org/apache/gravitino/audit/v2/TestCompatibilityUtils.java
+++ 
b/core/src/test/java/org/apache/gravitino/audit/v2/TestCompatibilityUtils.java
@@ -105,4 +105,10 @@ public class TestCompatibilityUtils {
     Assertions.assertEquals(
         Status.UNKNOWN, 
CompatibilityUtils.toAuditLogStatus(OperationStatus.UNKNOWN));
   }
+
+  @Test
+  void testOperationStatusNullHandling() {
+    Assertions.assertDoesNotThrow(() -> 
CompatibilityUtils.toAuditLogStatus(null));
+    Assertions.assertEquals(Status.UNKNOWN, 
CompatibilityUtils.toAuditLogStatus(null));
+  }
 }