yuqi1129 commented on code in PR #8062:
URL: https://github.com/apache/gravitino/pull/8062#discussion_r2278387906
##########
.github/workflows/build.yml:
##########
@@ -23,31 +23,39 @@ jobs:
with:
filters: |
source_changes:
- - '.github/**'
- - 'catalogs/**'
- - 'clients/**'
- - 'conf/**'
- - 'dev/**'
- - 'docs/open-api/**'
- - 'gradle/**'
- - 'gradle.properties'
- - 'meta/**'
- - 'scripts/**'
- - 'web/**'
- - '**/*.java'
- - '**/*.kts'
- - '**/*.py'
- - '**/*.rs'
- - '**/resources/**'
- - '**/src/**'
- - '!**/*.md'
- - '!**/*.png'
- - '!**/*.svg'
Review Comment:
> do we need to exclude mcp-server for most yml files? since mcp-server is
not in include list
The fact is: `'**/*.py'` may include most files in `mcp-server`, so we need
to exclude `mcp-server/**`.
##########
.github/workflows/build.yml:
##########
@@ -23,31 +23,39 @@ jobs:
with:
filters: |
source_changes:
- - '.github/**'
- - 'catalogs/**'
- - 'clients/**'
- - 'conf/**'
- - 'dev/**'
- - 'docs/open-api/**'
- - 'gradle/**'
- - 'gradle.properties'
- - 'meta/**'
- - 'scripts/**'
- - 'web/**'
- - '**/*.java'
- - '**/*.kts'
- - '**/*.py'
- - '**/*.rs'
- - '**/resources/**'
- - '**/src/**'
- - '!**/*.md'
- - '!**/*.png'
- - '!**/*.svg'
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
