jerryshao commented on code in PR #7829: URL: https://github.com/apache/gravitino/pull/7829#discussion_r2281196934
########## server/src/main/java/org/apache/gravitino/server/web/rest/StatisticOperations.java: ########## @@ -0,0 +1,200 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.gravitino.server.web.rest; + +import com.codahale.metrics.annotation.ResponseMetered; +import com.codahale.metrics.annotation.Timed; +import com.google.common.collect.Lists; +import com.google.common.collect.Maps; +import java.util.List; +import java.util.Locale; +import java.util.Map; +import javax.inject.Inject; +import javax.servlet.http.HttpServletRequest; +import javax.ws.rs.Consumes; +import javax.ws.rs.GET; +import javax.ws.rs.POST; +import javax.ws.rs.PUT; +import javax.ws.rs.Path; +import javax.ws.rs.PathParam; +import javax.ws.rs.Produces; +import javax.ws.rs.core.Context; +import javax.ws.rs.core.MediaType; +import javax.ws.rs.core.Response; +import org.apache.commons.lang3.StringUtils; +import org.apache.gravitino.MetadataObject; +import org.apache.gravitino.MetadataObjects; +import org.apache.gravitino.dto.requests.StatisticsDropRequest; +import org.apache.gravitino.dto.requests.StatisticsUpdateRequest; +import org.apache.gravitino.dto.responses.BaseResponse; +import org.apache.gravitino.dto.responses.DropResponse; +import org.apache.gravitino.dto.responses.StatisticListResponse; +import org.apache.gravitino.dto.util.DTOConverters; +import org.apache.gravitino.exceptions.IllegalStatisticNameException; +import org.apache.gravitino.metrics.MetricNames; +import org.apache.gravitino.server.web.Utils; +import org.apache.gravitino.stats.Statistic; +import org.apache.gravitino.stats.StatisticManager; +import org.apache.gravitino.stats.StatisticValue; +import org.apache.gravitino.utils.MetadataObjectUtil; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Path("/metalakes/{metalake}/objects/{type}/{fullName}/statistics") +@Consumes(MediaType.APPLICATION_JSON) +@Produces(MediaType.APPLICATION_JSON) +public class StatisticOperations { + + private static final Logger LOG = LoggerFactory.getLogger(StatisticOperations.class); + + @Context private HttpServletRequest httpRequest; + + private final StatisticManager statisticManager; + + @Inject + public StatisticOperations(StatisticManager statisticManager) { + this.statisticManager = statisticManager; + } + + @GET + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "list-stats." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "list-stats", absolute = true) + public Response listStatistics( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName) { + LOG.info( + "Received list statistics request for object full name: {} type: {} in the metalake {}", + fullName, + type, + metalake); + try { + MetadataObject object = + MetadataObjects.parse( + fullName, MetadataObject.Type.valueOf(type.toUpperCase(Locale.ROOT))); + if (object.type() != MetadataObject.Type.TABLE) { + throw new UnsupportedOperationException( + "Listing statistics is only supported for tables now."); + } + + return Utils.doAs( + httpRequest, + () -> { + MetadataObjectUtil.checkMetadataObject(metalake, object); + + List<Statistic> statistics = statisticManager.listStatistics(metalake, object); + return Utils.ok( + new StatisticListResponse( + DTOConverters.toDTOs(statistics.toArray(new Statistic[0])))); + }); + } catch (Exception e) { + return ExceptionHandlers.handleStatisticException(OperationType.LIST, fullName, metalake, e); + } + } + + @PUT + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "update-stats." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "update-stats", absolute = true) + public Response updateStatistics( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName, + StatisticsUpdateRequest request) { + try { + LOG.info( + "Received update statistics request for object full name: {} type: {} in the metalake {}", + fullName, + type, + metalake); + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + MetadataObject object = + MetadataObjects.parse( + fullName, MetadataObject.Type.valueOf(type.toUpperCase(Locale.ROOT))); + if (object.type() != MetadataObject.Type.TABLE) { + throw new UnsupportedOperationException( + "Listing statistics is only supported for tables now."); + } + Map<String, StatisticValue<?>> statisticMaps = Maps.newHashMap(); + for (Map.Entry<String, StatisticValue<?>> entry : request.getUpdates().entrySet()) { + // Current we only support custom statistics + if (!entry.getKey().startsWith(Statistic.CUSTOM_PREFIX)) { + throw new IllegalStatisticNameException( + "Statistic name must start with %s , but got: %s", + Statistic.CUSTOM_PREFIX, entry.getKey()); + } + + statisticMaps.put(entry.getKey(), entry.getValue()); + } + + MetadataObjectUtil.checkMetadataObject(metalake, object); + + statisticManager.updateStatistics(metalake, object, statisticMaps); + return Utils.ok(new BaseResponse(0)); + }); + } catch (Exception e) { + return ExceptionHandlers.handleStatisticException( + OperationType.UPDATE, StringUtils.join(request.getUpdates().keySet(), ","), fullName, e); + } + } + + @POST + @Produces("application/vnd.gravitino.v1+json") + @Timed(name = "drop-stats." + MetricNames.HTTP_PROCESS_DURATION, absolute = true) + @ResponseMetered(name = "drop-stats", absolute = true) + public Response dropStatistics( + @PathParam("metalake") String metalake, + @PathParam("type") String type, + @PathParam("fullName") String fullName, + StatisticsDropRequest request) { + try { + LOG.info( + "Received drop statistics request for object full name: {} type: {} in the metalake {}", + fullName, + type, + metalake); + return Utils.doAs( + httpRequest, + () -> { + request.validate(); + + MetadataObject object = + MetadataObjects.parse( + fullName, MetadataObject.Type.valueOf(type.toUpperCase(Locale.ROOT))); + if (object.type() != MetadataObject.Type.TABLE) { + throw new UnsupportedOperationException( + "Listing statistics is only supported for tables now."); + } + + MetadataObjectUtil.checkMetadataObject(metalake, object); + + statisticManager.dropStatistics( + metalake, object, Lists.newArrayList(request.getNames())); + return Utils.ok(new DropResponse(true)); Review Comment: Is it always true? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
