FANNG1 commented on code in PR #7877:
URL: https://github.com/apache/gravitino/pull/7877#discussion_r2284307221


##########
.github/workflows/build.yml:
##########
@@ -63,7 +63,9 @@ jobs:
           cache: 'gradle'
 
       - name: Build with Gradle
-        run: ./gradlew build -x test -PjdkVersion=8
+        run: |
+          ./gradlew build -x test
+          ./gradlew release -x test

Review Comment:
   Could we use a seperate step like 
   ```
   - name: Build release jar
     run: | 
        ./gradlew release
   ```



##########
.github/workflows/build.yml:
##########
@@ -63,7 +63,9 @@ jobs:
           cache: 'gradle'
 
       - name: Build with Gradle
-        run: ./gradlew build -x test -PjdkVersion=8
+        run: |
+          ./gradlew build -x test
+          ./gradlew release -x test

Review Comment:
   Could we use a seperate step like follow?
   ```
   - name: Build release jar
     run: | 
        ./gradlew release
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to