justinmclean opened a new issue, #8168:
URL: https://github.com/apache/gravitino/issues/8168

   ### What would you like to be improved?
   
   An NPE can potentially occur as hiddenProperties is not initialised.
   
   Here is a unit test showing that:
   ```
     @Test
     void testPropertiesWithoutHiddenProperties() {
       Fileset fileset = Mockito.mock(Fileset.class);
       ImmutableMap<String, String> properties =
           ImmutableMap.of("propA", "valueA", "propB", "valueB");
       Mockito.when(fileset.properties()).thenReturn(properties);
   
       EntityCombinedFileset entityCombinedFileset = 
EntityCombinedFileset.of(fileset);
   
       Assertions.assertEquals(properties, entityCombinedFileset.properties());
     }
   ```
   
   ### How should we improve?
   
   initialise hiddenProperties


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to