justinmclean opened a new issue, #8195:
URL: https://github.com/apache/gravitino/issues/8195

   ### What would you like to be improved?
   
   In 
flink-connector/flink/src/main/java/org/apache/gravitino/flink/connector/jdbc/JdbcPropertiesConverter.java
 there's a NPE as shown by this test:
   ```
    @Test
     public void testToJdbcCatalogPropertiesWithoutUrl() {
       Map<String, String> catalogPropertiesWithoutUrl = new 
HashMap<>(catalogProperties);
       
catalogPropertiesWithoutUrl.remove(JdbcPropertiesConstants.GRAVITINO_JDBC_URL);
       Assertions.assertThrows(
           NullPointerException.class,
           () ->
               getConverter(catalogPropertiesWithoutUrl)
                   .toFlinkCatalogProperties(catalogPropertiesWithoutUrl));
     }
   ```
   
   Note this test shows there an error and will need to be modified.
   
   ### How should we improve?
   
   Make it there's no NPE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to