(gravitino) branch main updated: [#8197]Improvement: update equality check to primitive in PathBasedMetaDataObject (#8230)

[jmclean]

This is an automated email from the ASF dual-hosted git repository.

jmclean pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git


The following commit(s) were added to refs/heads/main by this push:
     new dc4ccd68a2 [#8197]Improvement: update equality check to primitive in 
PathBasedMetaDataObject (#8230)
dc4ccd68a2 is described below

commit dc4ccd68a2e840e9cead7aaef342701660ba5bb5
Author: Sambhavi Pandey <48976443+pandeysam...@users.noreply.github.com>
AuthorDate: Thu Aug 21 05:43:02 2025 +0530

    [#8197]Improvement: update equality check to primitive in 
PathBasedMetaDataObject (#8230)
    
    ### What changes were proposed in this pull request?
    
    (Please outline the changes and how this PR fixes the issue.)
    update equality check to primitive in PathBasedMetaDataObject from
    Object.equals to ==
    ### Why are the changes needed?
    
    (Please clarify why the changes are needed. For instance,
      1. If you propose a new API, clarify the use case for a new API.
      2. If you fix a bug, describe the bug.)
    
    Fix: #8197
    
    ### Does this PR introduce _any_ user-facing change?
    
    (Please list the user-facing changes introduced by your change,
    including
      1. Change in user-facing APIs.
      2. Addition or removal of property keys.)
    
    ### How was this patch tested?
    Unit testing
    (Please test your changes, and provide instructions on how to test it:
    1. If you add a feature or fix a bug, add a test to cover your changes.
    2. If you fix a flaky test, repeat it for many times to prove it works.)
---
 .../authorization/common/PathBasedMetadataObject.java         |  2 +-
 .../authorization/common/TestPathBasedMetadataObject.java     | 11 +++++++++++
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git 
a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java
 
b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java
index 1b5151dddc..00aa0723ef 100644
--- 
a/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java
+++ 
b/authorizations/authorization-common/src/main/java/org/apache/gravitino/authorization/common/PathBasedMetadataObject.java
@@ -175,7 +175,7 @@ public class PathBasedMetadataObject implements 
AuthorizationMetadataObject {
         && Objects.equals(parent, that.parent)
         && Objects.equals(path, that.path)
         && Objects.equals(type, that.type)
-        && Objects.equals(recursive, that.recursive);
+        && recursive == that.recursive;
   }
 
   @Override
diff --git 
a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java
 
b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java
index 60b07159b7..9cfda13b94 100644
--- 
a/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java
+++ 
b/authorizations/authorization-common/src/test/java/org/apache/gravitino/authorization/common/TestPathBasedMetadataObject.java
@@ -95,4 +95,15 @@ public class TestPathBasedMetadataObject {
     Assertions.assertNotEquals(recursiveObject, nonRecursiveObject);
     Assertions.assertNotEquals(recursiveObject.hashCode(), 
nonRecursiveObject.hashCode());
   }
+
+  @Test
+  public void testEqualsWithDifferentRecursive() {
+    PathBasedMetadataObject recursiveObject =
+        new PathBasedMetadataObject(
+            "parent", "name", "path", PathBasedMetadataObject.FILESET_PATH, 
true);
+    PathBasedMetadataObject recursiveObject2 =
+        new PathBasedMetadataObject(
+            "parent", "name", "path", PathBasedMetadataObject.FILESET_PATH, 
true);
+    Assertions.assertEquals(recursiveObject, recursiveObject2);
+  }
 }