JeonDaehong opened a new pull request, #8255: URL: https://github.com/apache/gravitino/pull/8255
**What changes were proposed in this pull request?** In `GroupMetaService.java`, the `updateGroup` method had an early return when there were no role changes (`insertRoleIds.isEmpty() && deleteRoleIds.isEmpty()`), which caused other group changes like name updates or audit info modifications to be ignored. This PR removes the early return logic and ensures that group metadata is always updated, while role-specific operations are only performed when necessary. **Why are the changes needed?** Without this fix, updating a group's name or other non-role properties would be silently ignored if there were no role changes, leading to inconsistent behavior. Users expecting group renames or audit info updates would find their changes were not persisted to the database. Fixes #8201 **Does this PR introduce any user-facing change?** No. Valid requests now behave correctly where they previously failed silently. Group updates that don't involve role changes will now work as expected. **How was this patch tested?** * Added unit test `updateGroupWithoutRoleChange()` to verify that group name changes work without role modifications * Verified that the test fails with the old code and passes with the fix * Confirmed that existing role-based update functionality remains unchanged * All existing tests continue to pass, ensuring no regression in role management features -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@gravitino.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
