mchades commented on code in PR #8050:
URL: https://github.com/apache/gravitino/pull/8050#discussion_r2293780622
##########
bundles/aws/build.gradle.kts:
##########
@@ -40,15 +43,12 @@ dependencies {
exclude("*")
}
- implementation(libs.aws.iam)
- implementation(libs.aws.policy)
Review Comment:
> I also need to put `libs.aws.policy` and `libs.aws.iam` in the class path
to make it runs
Are you sure? If it's just simple file access, I think there's no need to
introduce these two dependencies. (the test `TestCredentialProvider` in this
module runs well and we only use `testImplementation(libs.aws.s3)`)
> Another point is that adding aws.jar to the classpath of Hadoop command
line should be fine to make Hadoop works, after this change, we needs more
extra packages.
we needs more extra packages like what?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
