hdygxsj commented on code in PR #8269:
URL: https://github.com/apache/gravitino/pull/8269#discussion_r2297843467


##########
server-common/src/main/java/org/apache/gravitino/server/authorization/jcasbin/JcasbinAuthorizer.java:
##########
@@ -309,8 +307,7 @@ private boolean loadPrivilegeAndAuthorize(
         userId = userEntity.id();
         metadataId = MetadataIdConverter.getID(metadataObject, metalake);
       } catch (Exception e) {
-        LOG.debug("Can not get entity id", e);
-        return false;
+        throw new RuntimeException(e);

Review Comment:
   We might want to swallow some exceptions and return false, while letting the 
remaining exceptions propagate. 
   
   Such as,
   
   ```
   java.lang.RuntimeException: 
org.apache.gravitino.exceptions.NoSuchEntityException: No such schema entity: 
default
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to