hqbhoho commented on code in PR #8188:
URL: https://github.com/apache/gravitino/pull/8188#discussion_r2299564919
##########
trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/hive/HiveMetadataAdapter.java:
##########
@@ -249,4 +251,14 @@ public ConnectorTableMetadata
getTableMetadata(GravitinoTable gravitinoTable) {
properties,
Optional.ofNullable(gravitinoTable.getComment()));
}
+
+ /**
+ * Get the column handle name that will generate row IDs for the merge
operation.
+ *
+ * @return the column handle name for row IDs
+ */
+ @Override
+ public String getMergeRowIdColumnHandleName() {
+ return MERGE_ROW_ID;
Review Comment:
Different connector will have different `mergeRowIdColumnHandle` which not
define in table schema. The name for `mergeRowIdColumnHandle` is also
different.
Currently, the column handle name is `$row_id` in Hive/Iceberg and
`$merge_row_id` in JDBC .
Even if the names are the same, I thibk they should be defined separately
within their respective connectors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
