mchades commented on code in PR #8254:
URL: https://github.com/apache/gravitino/pull/8254#discussion_r2300271737
##########
clients/filesystem-hadoop3/src/main/java/org/apache/gravitino/filesystem/hadoop/FilesetCatalogCache.java:
##########
@@ -80,6 +107,14 @@ private Cache<NameIdentifier, FilesetCatalog>
newCatalogCache(
.build();
}
+ private Cache<NameIdentifier, Fileset> newFilesetCache(
+ ScheduledThreadPoolExecutor filesetCleanScheduler) {
+ return Caffeine.newBuilder()
+ .maximumSize(100)
+
.scheduler(Scheduler.forScheduledExecutorService(filesetCleanScheduler))
Review Comment:
after I removed this scheduler, the cache tests failed (more details see
[here](https://github.com/apache/gravitino/actions/runs/17231457433/job/48886396015?pr=8254)):
> TestSimpleClient > testInternalCache() FAILED
> org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a Lambda expression in
org.apache.gravitino.filesystem.hadoop.TestGvfsBase expected: <0> but was: <1>
within 5 seconds.
> at
app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
> at
app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at
app//org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at
app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
> at
app//org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:790)
> at
app//org.apache.gravitino.filesystem.hadoop.TestGvfsBase.testInternalCache(TestGvfsBase.java:387)
> at
[email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
> at
[email protected]/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
[email protected]/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
[email protected]/java.lang.reflect.Method.invoke(Method.java:569)
I'll add it back and make it a local variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
