jerryshao commented on code in PR #8267:
URL: https://github.com/apache/gravitino/pull/8267#discussion_r2300703219
##########
clients/client-java/src/main/java/org/apache/gravitino/client/GenericModelCatalog.java:
##########
@@ -240,6 +242,54 @@ public void linkModelVersion(
resp.validate();
}
+ @Override
+ public String getModelVersionUri(NameIdentifier ident, int version, String
uriName)
+ throws NoSuchModelVersionException, NoSuchModelVersionURINameException {
+ checkModelNameIdentifier(ident);
+ Preconditions.checkArgument(version >= 0, "Model version must be
non-negative");
+
+ NameIdentifier modelFullIdent = modelFullNameIdentifier(ident);
+ Map<String, String> queryParam =
+ uriName == null
+ ? Collections.emptyMap()
+ : ImmutableMap.of("uriName", RESTUtils.encodeString(uriName));
Review Comment:
You don't have to encode the query parameter, the Apache Http client will
help you to do so:
<img width="752" height="303" alt="image"
src="https://github.com/user-attachments/assets/1218d9fd-17d6-4294-8958-8c97cc6fd292";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
