jerryshao commented on code in PR #8228:
URL: https://github.com/apache/gravitino/pull/8228#discussion_r2303004680
##########
core/src/main/java/org/apache/gravitino/stats/StatisticManager.java:
##########
@@ -58,7 +58,7 @@
public class StatisticManager implements Closeable {
- private static final String OPTIONS_PREFIX =
"gravitino.stats.partition.option.";
+ private static final String OPTIONS_PREFIX = "gravitino.partition.stats.";
Review Comment:
Also, it is better to fix the code in `StatisticManager` to filter out the
configurations for the specific storage:
```
String className =
config.get(Configs.PARTITION_STATS_STORAGE_FACTORY_CLASS);
Map<String, String> options =
config.getConfigsWithPrefix(OPTIONS_PREFIX);
try {
PartitionStatisticStorageFactory factory =
(PartitionStatisticStorageFactory)
Class.forName(className).getDeclaredConstructor().newInstance();
this.partitionStorage = factory.create(options);
```
So the specific storage doesn't need to take care the prefix like `lance.`.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
