justinmclean opened a new issue, #8301:
URL: https://github.com/apache/gravitino/issues/8301
### What would you like to be improved?
Improve ParseType.parseBasicType so it accepts whitespace around numeric
parameters.
Here's two tests to illustrate what is needed:
```
@Test
public void testParseTypeDecimalWithSpaces() {
Type type = ParseType.toType("decimal(10, 5)");
assertThat(type, instanceOf(Types.DecimalType.class));
assertEquals(10, ((Types.DecimalType) type).precision());
assertEquals(5, ((Types.DecimalType) type).scale());
}
@Test
public void testParseTypeVarcharWithSpaces() {
Type type = ParseType.toType("varchar( 10 )");
assertThat(type, instanceOf(Types.VarCharType.class));
assertEquals(10, ((Types.VarCharType) type).length());
}
```
### How should we improve?
as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
