justinmclean opened a new issue, #8306: URL: https://github.com/apache/gravitino/issues/8306
### What would you like to be improved? In ScriptRunner, conn.rollback() will always be called (as it's in a finally block). However, this could possibly lead to issues with auto-commit connections. The rollback should only occur when auto-commit is set to false. Also, I think the conn.rollback() should be in the exception block, otherwise, it will also be called directly after a commit, while this has no impact, it seems unnecessary. ### How should we improve? Only rollback auto-commit is set to false and there is an exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
