keepConcentration opened a new pull request, #8324:
URL: https://github.com/apache/gravitino/pull/8324
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
- Added validation in `FilesetCommandHandler.handleUpdateCommand()` to exit
with an error when both `--comment` and `--rename` options are missing for the
`fileset update` command.
- Introduced new error message constant `MISSING_COMMENT_AND_RENAME`.
- Added a unit test `testUpdateFilesetCommandWithoutOptions`.
### Why are the changes needed?
Currently, the `fileset update` command can be executed without providing
`--comment` or `--rename` options, which results in a no-op operation.
Fix: #8283
### Does this PR introduce _any_ user-facing change?
Yes.
- Running `fileset update` without `--comment` or `--rename` will now exit
with an error message:
```
Missing --comment and --rename options.
```
### How was this patch tested?
1. Executed a unit test `testUpdateFilesetCommandWithoutOptions()`
2. Executed existing unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
