dcarpentiero opened a new pull request, #8360: URL: https://github.com/apache/gravitino/pull/8360
Title: [#8308] fix(iceberg): throw TrinoException when `catalog-backend` is missing ### What changes were proposed in this pull request? - Add an explicit check for a missing `catalog-backend` in `gravitinoToEngineProperties(...)` and throw a `TrinoException` with `GravitinoErrorCode.GRAVITINO_MISSING_REQUIRED_PROPERTY`. - Keep existing backend property validators unchanged. - No other functional changes. ### Why are the changes needed? - Prevent a potential `NullPointerException` when switching on a `null` backend. - Align behavior with existing code paths and the review request. Fixes: #8308 ### Does this PR introduce any user-facing change? - No breaking changes. - Users now receive a clear error when the required `catalog-backend` property is missing. ### How was this patch tested? - Existing tests pass. - Added/updated a unit test asserting that a `TrinoException` is thrown when `catalog-backend` is absent. - Manual verification of error message and code. Files touched: - `trino-connector/trino-connector/src/main/java/org/apache/gravitino/trino/connector/catalog/iceberg/IcebergCatalogPropertyConverter.java` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
