yuqi1129 commented on code in PR #8297:
URL: https://github.com/apache/gravitino/pull/8297#discussion_r2318348823
##########
core/src/main/java/org/apache/gravitino/storage/relational/RelationalEntityStore.java:
##########
@@ -116,7 +116,6 @@ public <E extends Entity & HasIdentifier> void put(E e,
boolean overwritten)
cache.put(e);
}
- @Override
Review Comment:
Why do we remove the annotation here? Is it by design?
##########
core/src/main/java/org/apache/gravitino/authorization/PermissionManager.java:
##########
@@ -81,6 +85,17 @@ User grantRolesToUser(String metalake, List<String> roles,
String user) {
UserEntity.class,
Entity.EntityType.USER,
userEntity -> {
+ if (store instanceof EntityCache) {
Review Comment:
What do you mean by `I'm not sure the grammar is ok`? I can't get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
