hqbhoho commented on code in PR #8419:
URL: https://github.com/apache/gravitino/pull/8419#discussion_r2328987617
##########
trino-connector/integration-test/src/test/java/org/apache/gravitino/trino/connector/integration/test/TrinoQueryTestTool.java:
##########
@@ -85,6 +85,13 @@ public static void main(String[] args) throws Exception {
"Additional parameters that can replace the value of ${key} in the
testers contents, "
+ "example: --params=key1,v1;key2,v2");
+ options.addOption(
+ "trino_worker_num",
+ true,
+ "Specify the number of Trino worker, the default value is 0."
Review Comment:
> Is better the default value is 1 . The coordinator node is indclude one
work in the current configuration
- 0 is a single node that functions as both a coordinator and worker(current
ci behavior). This scenario can be considered as having no independent workers,
coordinator work as worker.
- 1 is two node which one is coordinator and one is independent worker.
Or change the name `trino_worker_num` to `trino_independent_worker_num`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
