yuqi1129 commented on code in PR #8456:
URL: https://github.com/apache/gravitino/pull/8456#discussion_r2331777852
##########
catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java:
##########
@@ -217,7 +217,7 @@ public void alterTable(String databaseName, String
tableName, TableChange... cha
String sql = generateAlterTableSql(databaseName, tableName, change);
if (StringUtils.isEmpty(sql)) {
LOG.info("No changes to alter table {} from database {}", tableName,
databaseName);
- return;
+ continue;
Review Comment:
I'm generally okay with the change. @mchades, please also check if we
intentionally return directly if the SQL string is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
