jerqi commented on code in PR #8102:
URL: https://github.com/apache/gravitino/pull/8102#discussion_r2335797845
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/MetadataFilterHelper.java:
##########
@@ -214,4 +281,23 @@ private static boolean enableAuthorization() {
Config config = GravitinoEnv.getInstance().config();
return config != null && config.get(Configs.ENABLE_AUTHORIZATION);
}
+
+ private static void checkExecutor() {
+ if (executor == null) {
+ synchronized (MetadataFilterHelper.class) {
+ if (executor == null) {
+ executor =
+ Executors.newFixedThreadPool(
+ GravitinoEnv.getInstance()
+ .config()
+
.get(Configs.ENTITY_RELATIONAL_JDBC_BACKEND_MAX_CONNECTIONS),
+ runnable -> {
+ Thread thread = new Thread(runnable);
Review Comment:
If the thread isn't the daemon thread, it will block the shutdown of the
server.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
