yuqi1129 commented on code in PR #8487:
URL: https://github.com/apache/gravitino/pull/8487#discussion_r2336623847
##########
clients/client-python/tests/integration/containers/base_container.py:
##########
@@ -90,6 +91,44 @@ def _fetch_ip(self):
def get_ip(self):
return self._ip
+ def get_tar_from_dock(self, src_path: str, dest_path: str):
Review Comment:
dock or docker?
##########
clients/client-python/tests/integration/containers/base_container.py:
##########
@@ -90,6 +91,44 @@ def _fetch_ip(self):
def get_ip(self):
return self._ip
+ def get_tar_from_dock(self, src_path: str, dest_path: str):
Review Comment:
It's better to rename the method to `copy_file_from_docker`
##########
clients/client-python/build.gradle.kts:
##########
@@ -47,6 +47,7 @@ fun waitForServerIsReady(host: String = "http://localhost";,
port: Int = 8090, ti
val urlString = "$host:$port/metrics"
val successPattern = Regex("\"version\"\\s*:")
+ println("Waiting for server to be ready at $urlString (timeout: ${timeout /
1000}s)...")
Review Comment:
Will you keep the debug information?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
