jerryshao commented on code in PR #8635:
URL: https://github.com/apache/gravitino/pull/8635#discussion_r2366617323
##########
core/src/main/java/org/apache/gravitino/storage/relational/service/TableMetaService.java:
##########
@@ -182,9 +190,9 @@ public <E extends Entity & HasIdentifier> TableEntity
updateTable(
updateResult.set(
SessionUtils.getWithoutCommit(
TableMetaMapper.class,
- mapper -> mapper.updateTableMeta(newTablePO,
oldTablePO))),
+ mapper -> mapper.updateTableMeta(newTablePO, oldTablePO,
newSchemaId))),
() -> {
- if (updateResult.get() > 0 && isColumnChanged) {
+ if (updateResult.get() > 0 && (isColumnChanged ||
isSchemaChanged)) {
Review Comment:
You should add the tests to cover the changes in meta service here and bove.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
