sunxiaojian commented on code in PR #8592:
URL: https://github.com/apache/gravitino/pull/8592#discussion_r2366671567
##########
common/src/main/java/org/apache/gravitino/credential/CredentialPropertyUtils.java:
##########
@@ -46,6 +46,20 @@ public class CredentialPropertyUtils {
@VisibleForTesting
static final String ICEBERG_ADLS_ACCOUNT_KEY =
"adls.auth.shared-key.account.key";
+ // Map from credential types to their corresponding storage system prefixes
+ // Only includes the types supported by toIcebergProperties method
+ private static final Map<Class<? extends Credential>, String>
CREDENTIAL_TYPE_TO_PREFIX_MAP =
Review Comment:
> ok, then I'll reimplement an iceberg Credential, since ImmutableCredential
doesn't allow ignoring the prefix
If the implementation involves using the prefix in logical processing during
usage, this approach would be problematic. However, it is currently believed
that the client should not use it; only the Credential is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
