yuqi1129 commented on code in PR #7714:
URL: https://github.com/apache/gravitino/pull/7714#discussion_r2377528057
##########
common/src/main/java/org/apache/gravitino/dto/rel/PartitionUtils.java:
##########
@@ -39,7 +39,10 @@ public static void validateFieldExistence(ColumnDTO[]
columns, String[] fieldNam
throws IllegalArgumentException {
Preconditions.checkArgument(ArrayUtils.isNotEmpty(columns), "columns
cannot be null or empty");
Preconditions.checkArgument(
- ArrayUtils.isNotEmpty(fieldName), "fieldName cannot be null or empty");
+ ArrayUtils.isNotEmpty(fieldName) &&
StringUtils.isNotBlank(fieldName[0]),
+ "fieldName cannot be null or empty");
+
+ ArrayUtils.isNotEmpty((fieldName), "fieldName cannot be null or empty");
Review Comment:
Why do you need to check `fieldName` again, as you have done it in L42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
