This is an automated email from the ASF dual-hosted git repository.
fanng pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/gravitino.git
The following commit(s) were added to refs/heads/main by this push:
new 07873dd3d1 [#8748] Improvement: replace with proper exec run of the
server process (#8749)
07873dd3d1 is described below
commit 07873dd3d13bfbd10b49ffd379a46091fe981224
Author: Shunki <[email protected]>
AuthorDate: Fri Oct 10 16:52:19 2025 +0900
[#8748] Improvement: replace with proper exec run of the server process
(#8749)
### What changes were proposed in this pull request?
Replace the dummy tail -f /dev/null with an exec call that directly runs
the server in the foreground.
### Why are the changes needed?
This is only a dummy way to keep the container alive, not a correct
process management approach.
Fix: #8748
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
UTs
---
dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh | 7 -------
dev/docker/iceberg-rest-server/start-iceberg-rest-server.sh | 2 +-
2 files changed, 1 insertion(+), 8 deletions(-)
diff --git a/dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh
b/dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh
index 06033371e8..46af507705 100755
--- a/dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh
+++ b/dev/docker/iceberg-rest-server/iceberg-rest-server-dependency.sh
@@ -73,10 +73,3 @@ cp bundles/*jar
${iceberg_rest_server_dir}/packages/gravitino-iceberg-rest-serve
cp start-iceberg-rest-server.sh
${iceberg_rest_server_dir}/packages/gravitino-iceberg-rest-server/bin/
cp rewrite_config.py
${iceberg_rest_server_dir}/packages/gravitino-iceberg-rest-server/bin/
-
-# Keeping the container running at all times
-cat <<EOF >>
"${iceberg_rest_server_dir}/packages/gravitino-iceberg-rest-server/bin/gravitino-iceberg-rest-server.sh"
-
-# Keeping a process running in the background
-tail -f /dev/null
-EOF
diff --git a/dev/docker/iceberg-rest-server/start-iceberg-rest-server.sh
b/dev/docker/iceberg-rest-server/start-iceberg-rest-server.sh
index 449ed5ebf5..ab52f8088b 100755
--- a/dev/docker/iceberg-rest-server/start-iceberg-rest-server.sh
+++ b/dev/docker/iceberg-rest-server/start-iceberg-rest-server.sh
@@ -26,4 +26,4 @@ cd ${iceberg_rest_server_dir}
python bin/rewrite_config.py
-./bin/gravitino-iceberg-rest-server.sh start
+exec ./bin/gravitino-iceberg-rest-server.sh run