yuqi1129 commented on code in PR #8793:
URL: https://github.com/apache/gravitino/pull/8793#discussion_r2427847146


##########
.github/workflows/build.yml:
##########
@@ -135,6 +135,9 @@ jobs:
       - name: Build with Gradle
         run: ./gradlew build -PskipITs -PjdkVersion=${{ matrix.java-version }} 
-PskipDockerTests=false -x :clients:client-python:build
 
+      - name: Release with Gradle
+        run: ./gradlew release -x test -PjdkVersion=${{ matrix.java-version }}

Review Comment:
   > Why do we need to specify the jdk version for release
   
   There is only one JDK version(JDK17) here,  and I just copied it from 
`./gradlew build`.
   
   >  Another thing is that we'd better clean and recompile for release to 
avoid skipping of gradle tasks - which may hide the problem. Can you please 
verify it more locally?
   
   Okay, I will test locally and then update the CI accordingly. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to