FANNG1 commented on code in PR #8782: URL: https://github.com/apache/gravitino/pull/8782#discussion_r2422442116
########## core/src/main/java/org/apache/gravitino/listener/api/event/job/RegisterJobTemplatePreEvent.java: ########## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.job; + +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.job.JobTemplate; +import org.apache.gravitino.listener.api.event.OperationType; +import org.apache.gravitino.listener.api.event.PreEvent; +import org.apache.gravitino.utils.NameIdentifierUtil; + +/** Represents an event triggered before the registration of a job template. */ +@DeveloperApi +public class RegisterJobTemplatePreEvent extends PreEvent { Review Comment: Could you use a abstract `JobTemplatePreEvent` for all xxJobTemplatePreEvent? ########## core/src/main/java/org/apache/gravitino/listener/api/event/job/GetJobTemplateEvent.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.gravitino.listener.api.event.job; + +import org.apache.gravitino.annotation.DeveloperApi; +import org.apache.gravitino.job.JobTemplate; +import org.apache.gravitino.listener.api.event.OperationType; +import org.apache.gravitino.utils.NameIdentifierUtil; + +/** Represents an event triggered when a job template has been successfully retrieved. */ +@DeveloperApi +public class GetJobTemplateEvent extends JobTemplateEvent { + + private final JobTemplate jobTemplate; + + /** + * Constructs a new {@code GetJobTemplateEvent} instance. + * + * @param user The user who initiated the job template retrieval operation. + * @param metalake The metalake name where the job template resides. + * @param jobTemplate The job template that has been retrieved. + */ + public GetJobTemplateEvent(String user, String metalake, JobTemplate jobTemplate) { + super(user, NameIdentifierUtil.ofJobTemplate(metalake, jobTemplate.name())); + this.jobTemplate = jobTemplate; + } + + /** + * Returns the job template that has been retrieved. + * + * @return the retrieved job template + */ + public JobTemplate retrievedJobTemplate() { Review Comment: Should we use `loadedJobTemplate` to keep consistent with other GetxxEvents? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
