jerryshao commented on code in PR #8742:
URL: https://github.com/apache/gravitino/pull/8742#discussion_r2418370316
##########
catalogs/catalog-common/src/main/java/org/apache/gravitino/utils/ClassLoaderResourceCleanerUtils.java:
##########
@@ -221,6 +221,19 @@ private static void clearShutdownHooks(ClassLoader
targetClassLoader) throws Exc
*/
private static void releaseLogFactoryInCommonLogging(ClassLoader
currentClassLoader)
throws Exception {
+
+ // If we use fileset with the local file system, HTrace will be used, so
we need to
+ // release the HTrace LogFactory as well.
+ try {
+ Class<?> htraceLogFactoryClass =
+ Class.forName(
+ "org.apache.htrace.shaded.commons.logging.LogFactory", true,
currentClassLoader);
+ MethodUtils.invokeStaticMethod(htraceLogFactoryClass, "release",
currentClassLoader);
+ } catch (Exception e) {
+ // Ignore if htrace is not used
+ LOG.debug("HTrace is not used, skipping release of HTrace
LogFactory...");
Review Comment:
Can you please change all the log levels in this file to debug or trace log?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
