jerryshao commented on code in PR #8879:
URL: https://github.com/apache/gravitino/pull/8879#discussion_r2460136333
##########
core/src/main/java/org/apache/gravitino/catalog/TableOperationDispatcher.java:
##########
@@ -487,6 +491,19 @@ private EntityCombinedTable importTable(NameIdentifier
identifier) {
}
private EntityCombinedTable internalLoadTable(NameIdentifier ident) {
+ NameIdentifier catalogIdent = getCatalogIdentifier(ident);
+ if (isGenericLakehouseCatalog(catalogIdent)) {
+ try {
+ GenericTableEntity tableEntity = store.get(ident, TABLE,
GenericTableEntity.class);
+ if (tableEntity != null) {
+ GenericTable genericTable = tableEntity.toGenericTable();
+ return EntityCombinedTable.of(genericTable).withImported(true);
+ }
+ } catch (IOException ioe) {
+ throw new RuntimeException("Failed to load table entity " + ident,
ioe);
+ }
+ }
Review Comment:
Check how `ManagedSchemaOperations` is implemented, don't do lots of special
if..else check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
