yuqi1129 commented on code in PR #8923:
URL: https://github.com/apache/gravitino/pull/8923#discussion_r2468261371
##########
core/src/main/java/org/apache/gravitino/storage/relational/utils/POConverters.java:
##########
@@ -457,17 +457,35 @@ public static TablePO updateTablePOWithVersionAndSchemaId(
}
try {
- return TablePO.builder()
- .withTableId(oldTablePO.getTableId())
- .withTableName(newTable.name())
- .withMetalakeId(oldTablePO.getMetalakeId())
- .withCatalogId(oldTablePO.getCatalogId())
- .withSchemaId(newSchemaId)
-
.withAuditInfo(JsonUtils.anyFieldMapper().writeValueAsString(newTable.auditInfo()))
- .withCurrentVersion(currentVersion)
- .withLastVersion(lastVersion)
- .withDeletedAt(DEFAULT_DELETED_AT)
- .build();
+ TablePO.Builder builder =
+ TablePO.builder()
+ .withTableId(oldTablePO.getTableId())
+ .withTableName(newTable.name())
+ .withMetalakeId(oldTablePO.getMetalakeId())
+ .withCatalogId(oldTablePO.getCatalogId())
+ .withSchemaId(newSchemaId)
+
.withAuditInfo(JsonUtils.anyFieldMapper().writeValueAsString(newTable.auditInfo()))
+ .withCurrentVersion(currentVersion)
+ .withLastVersion(lastVersion)
+ .withDeletedAt(DEFAULT_DELETED_AT);
+
+ // Note: GenericTableEntity will be removed in the refactor PR, so here
just keep the old
+ // logic to make the UT pass.
+ if (newTable instanceof GenericTableEntity genericTable) {
Review Comment:
This is a temporary change to make the CI pass, and #8922 will remove the
class `GenericTableEntity` and use `TableEntity`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
