jerqi commented on code in PR #8941:
URL: https://github.com/apache/gravitino/pull/8941#discussion_r2471851136
##########
server-common/src/main/java/org/apache/gravitino/server/authorization/expression/AuthorizationExpressionEvaluator.java:
##########
@@ -89,8 +89,9 @@ public boolean evaluate(
public boolean evaluate(
Map<Entity.EntityType, NameIdentifier> metadataNames,
AuthorizationRequestContext requestContext,
- Principal principal) {
- return evaluate(metadataNames, new HashMap<>(), requestContext, principal);
+ Principal principal,
+ String entityType) {
+ return evaluate(metadataNames, new HashMap<>(), requestContext, principal,
entityType);
Review Comment:
If the parameter is null, we would better to use optional.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
